Is this a good work out and how long till i see good results?

I lift weights every 2 days till it burns, I do intense upper body work outs that includes biceps triceps shoulders pecs etc, then I drink weight gainer and rest for 2 days then repeat the proccess, is this good? And what results should I expect? And how long till I see them?, also is it any better if I do a cardio on my rest days?